make scaling pipeline plot on failure #2034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nefrathenrici
force-pushed
the
ne/scaling_hotfix
branch
from
8a34322 to
9bb4b9d
Compare
nefrathenrici
changed the title
nefrathenrici
force-pushed
the
ne/scaling_hotfix
branch
from
9bb4b9d to
28d774d
Compare
simonbyrne
approved these changes
Aug 29, 2023
|
Does the script still work in this case? |
@simonbyrne I think the plotting script will only break if there are no files to plot from, it works if there is at least one data point. One other thing - the scaling efficiency metric only seems to make work properly if there is a single-core 100% efficient run to use as a baseline. |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Aug 29, 2023
2034: make scaling pipeline plot on failure r=nefrathenrici a=nefrathenrici The plotting jobs in the scaling pipeline don't run if a prior job fails, this needs to be fixed. Test scaling build: https://buildkite.com/clima/climaatmos-scaling/builds/506#018a427c-39c0-45f1-a03c-0a44b6a7c722 Co-authored-by: nefrathenrici <nat.henrici@gmail.com>
|
Canceled. |
|
bors r+ |
|
bors r- |
|
bors r+ |
|
Already running a review |
bors bot
added a commit
that referenced
this pull request
Aug 29, 2023
2034: make scaling pipeline plot on failure r=nefrathenrici a=nefrathenrici The plotting jobs in the scaling pipeline don't run if a prior job fails, this needs to be fixed. Test scaling build: https://buildkite.com/clima/climaatmos-scaling/builds/506#018a427c-39c0-45f1-a03c-0a44b6a7c722 Co-authored-by: nefrathenrici <nat.henrici@gmail.com>
|
Canceled. |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Aug 29, 2023
2034: make scaling pipeline plot on failure r=nefrathenrici a=nefrathenrici The plotting jobs in the scaling pipeline don't run if a prior job fails, this needs to be fixed. Test scaling build: https://buildkite.com/clima/climaatmos-scaling/builds/506#018a427c-39c0-45f1-a03c-0a44b6a7c722 Co-authored-by: nefrathenrici <nat.henrici@gmail.com>
|
Canceled. |
|
bors r- |
|
bors r+ |
|
Canceled. |
|
bors r+ |
|
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The plotting jobs in the scaling pipeline don't run if a prior job fails, this needs to be fixed.
Test scaling build: https://buildkite.com/clima/climaatmos-scaling/builds/506#018a427c-39c0-45f1-a03c-0a44b6a7c722