Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use z-z_sfc in edmf closure #2041

Merged
merged 1 commit into from
Sep 1, 2023
Merged

use z-z_sfc in edmf closure #2041

merged 1 commit into from
Sep 1, 2023

Conversation

szy21
Copy link
Member

@szy21 szy21 commented Aug 30, 2023

Purpose

Closes #2028

To-do

Content


  • I have read and checked the items on the review checklist.

@szy21 szy21 requested a review from trontrytel August 30, 2023 23:58
@szy21 szy21 force-pushed the zs/edmf_closure_zsfc branch from 11e62ad to 7d42ee8 Compare August 31, 2023 23:03
@szy21
Copy link
Member Author

szy21 commented Aug 31, 2023

bors r+

@bors
Copy link
Contributor

bors bot commented Sep 1, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit 3e833df into main Sep 1, 2023
6 checks passed
@bors bors bot deleted the zs/edmf_closure_zsfc branch September 1, 2023 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix the closures with topography (it should always use z - z_sfc)
2 participants