trying to get rid of MSLP overwrite

[trontrytel]

No description provided.

[trontrytel]

cc: @szy21 - could you take a look when you have the time? I basically changed MSLP to p_ref_theta any time I saw it next to potential temperature. But I wasn't sure about the Held-Suarez forcing and some of the initial conditions.

I think the changed cases in the CI look fine. One timed-out on me. I'll retry.

cc: @nefrathenrici - looks promising!

[szy21]

I think it might be more consistent to change MSLP to p_ref_theta in the initial conditions in this file as it is used in p = p_0 * π_exn^(cp_d / R_d), so π_exn = (p / p_0)^(R_d/cp_d) when p_0 = p_ref_theta. It probably doesn't matter much though, as it is just the initial condition.

[trontrytel]

I kept the MSLP in the isothermal one and in the baroclinic wave initial conditions, but changed the rest. Lets see what the CI thinks about that

[szy21]

The changes look good to me, thanks!

[trontrytel]

bors r+

[bors]

Build failed:

• buildkite/climaatmos-ci

[trontrytel]

bors r+

[bors]

Build failed:

• docbuild

[szy21]

bors r+

[bors]

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

• buildkite/climaatmos-ci
• docbuild
• format

[charleskawczynski]

Amazing work, everyone! 👏👏👏

I tried doing this years ago, and was unsuccessful, it’s great to see that this is finally fixed!