Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 4 process run for dry baroclinic wave #2155

Merged
merged 1 commit into from
Sep 28, 2023
Merged

Add 4 process run for dry baroclinic wave #2155

merged 1 commit into from
Sep 28, 2023

Conversation

sriharshakandala
Copy link
Member

Purpose

Add 4 process run for dry baroclinic wave

  • I have read and checked the items on the review checklist.

@sriharshakandala sriharshakandala linked an issue Sep 25, 2023 that may be closed by this pull request
Add multi-GPU performance case to pipeline #2154
Closed
@simonbyrne simonbyrne marked this pull request as ready for review September 27, 2023 22:24
@simonbyrne
Copy link
Member

I think squash this, then it's good to merge.

@sriharshakandala
Copy link
Member Author

I think squash this, then it's good to merge.

I can move the moist simulation to a different PR, since this is currently not working on the GPU!

@simonbyrne
Copy link
Member

might as well leave it: we will need it at some point.

@sriharshakandala sriharshakandala force-pushed the sk/add_distributed_gpu_run branch from 1b946b4 to e9538ec Compare September 27, 2023 22:38
@sriharshakandala
Copy link
Member Author

bors r+

bors bot added a commit that referenced this pull request Sep 27, 2023
@bors @sriharshakandala
Merge #2155
3c7aef4 
2155: Add 4 process run for dry baroclinic wave r=sriharshakandala a=sriharshakandala



Co-authored-by: sriharshakandala <sriharsha.kvs@gmail.com>
@bors
Copy link
Contributor

bors bot commented Sep 27, 2023

Build failed:

@simonbyrne
Copy link
Member

bors r+

bors bot added a commit that referenced this pull request Sep 28, 2023
@bors @sriharshakandala
Merge #2155
bdc49f6 
2155: Add 4 process run for dry baroclinic wave r=simonbyrne a=sriharshakandala



Co-authored-by: sriharshakandala <sriharsha.kvs@gmail.com>
@bors
Copy link
Contributor

bors bot commented Sep 28, 2023

Build failed:

@sriharshakandala
Copy link
Member Author

bors r+

bors bot added a commit that referenced this pull request Sep 28, 2023
@bors @sriharshakandala @szy21
Merge #2155 #2164
3ed5dbf 
2155: Add 4 process run for dry baroclinic wave r=sriharshakandala a=sriharshakandala



2164: limit mixing length by z - z_sfc r=szy21 a=szy21



Co-authored-by: sriharshakandala <sriharsha.kvs@gmail.com>
Co-authored-by: Zhaoyi Shen <11598433+szy21@users.noreply.github.com>
@bors
Copy link
Contributor

bors bot commented Sep 28, 2023

Build failed (retrying...):

@bors
Copy link
Contributor

bors bot commented Sep 28, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit 794e24d into main Sep 28, 2023
6 checks passed
@bors bors bot deleted the sk/add_distributed_gpu_run branch September 28, 2023 19:04
@sriharshakandala sriharshakandala linked an issue Oct 2, 2023 that may be closed by this pull request
GPU benchmark for moist case #2156
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonbyrne simonbyrne simonbyrne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GPU benchmark for moist case Add multi-GPU performance case to pipeline
2 participants
@sriharshakandala @simonbyrne