Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix docs #2176

Merged
merged 3 commits into from
Oct 2, 2023
Merged

Fix docs #2176

merged 3 commits into from
Oct 2, 2023

Conversation

charleskawczynski
Copy link
Member

@charleskawczynski charleskawczynski commented Oct 1, 2023 •
edited
Loading

I think that this should close #2068. Documenter is now strict by default, so that keyword was removed.

@charleskawczynski charleskawczynski added the documentation Improvements or additions to documentation label Oct 1, 2023
@charleskawczynski
Copy link
Member Author

charleskawczynski commented Oct 1, 2023 •
edited
Loading

@Sbozzolo, please reopen #2068 if it doesn't close it. I think this should at least the docs for Documenter 1.x.y.

@charleskawczynski
Copy link
Member Author

bors r+

bors bot added a commit that referenced this pull request Oct 1, 2023
@bors @charleskawczynski
Merge #2176
15f460b 
2176: Fix docs r=charleskawczynski a=charleskawczynski

I think that this should close #2068. Documenter is now strict by default, so that keyword was removed.

Co-authored-by: Charles Kawczynski <kawczynski.charles@gmail.com>
@bors
Copy link
Contributor

bors bot commented Oct 1, 2023

Canceled.

@charleskawczynski
Copy link
Member Author

bors r+

@bors
Copy link
Contributor

bors bot commented Oct 2, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit 0dc8e1e into main Oct 2, 2023
8 checks passed
@bors bors bot deleted the ck/fix_docs branch October 2, 2023 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sbozzolo Sbozzolo Awaiting requested review from Sbozzolo

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DocumenterCitation error in generating documentation
1 participant
@charleskawczynski