Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix docs plugin error #2188

Merged
merged 1 commit into from
Oct 4, 2023
Merged

fix docs plugin error #2188

merged 1 commit into from
Oct 4, 2023

Conversation

nefrathenrici
Copy link
Member

@nefrathenrici nefrathenrici commented Oct 4, 2023

I think that bib needs to be passed into the plugin kwarg for doctest

Current Main (Merge #2186) still produces errors.

Current Branch does not have errors. There are some warnings related to specific citations.

@nefrathenrici nefrathenrici marked this pull request as ready for review October 4, 2023 17:33
@nefrathenrici nefrathenrici requested a review from Sbozzolo October 4, 2023 17:34
@Sbozzolo
Copy link
Member

Sbozzolo commented Oct 4, 2023

Thanks! We recently updated to Documenter 1.0 which added the plugin keyword. See #2068.

Maybe you could also tackle the warnings since you are looking at it? (Or ping someone to fix them)

@nefrathenrici
Copy link
Member Author

bors r+

@bors
Copy link
Contributor

bors bot commented Oct 4, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit 641cdeb into main Oct 4, 2023
8 checks passed
@bors bors bot deleted the ne/doc_error branch October 4, 2023 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants