-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add advective edmf #2213
Add advective edmf #2213
Conversation
901e1b4
to
6f5a774
Compare
913717b
to
2a57d48
Compare
259e876
to
d48489b
Compare
bac57de
to
fa8a633
Compare
@@ -723,6 +723,58 @@ steps: | |||
julia --color=yes --project=examples examples/hybrid/driver.jl | |||
--config_file $CONFIG_PATH/sphere_baroclinic_wave_rhoe_equilmoist_edmfx.yml | |||
artifact_paths: "sphere_baroclinic_wave_rhoe_equilmoist_edmfx/*" | |||
soft_fail: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know why I broke this sphere flux form edmfx :( But we will remove it anyway.
73d6da7
to
d9f6a31
Compare
1c14194
to
72ccded
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good luck!
43ae7a5
to
a34d052
Compare
a34d052
to
c761d97
Compare
bors r+ |
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
Purpose
Adds advective form EDMF. It uses h_tot and q_tot as prognostic variables. Currently we didn't add any other tracers.
We use
ConstantCoefficient
for entrainment. For detrainment, I changed the currentConstantCoefficient
toBOverW
, which is something like w * (coeff1 + coeff2 * b/w^2), so we can do either the old constant coefficient or the new w * (b/w^2 + const) detrainment. I think this is better as we don't need to include too many options. I wanted to change the names of current entrainment and detrainment closures as it is somewhat confusing. For example,ConstantCoefficient
meansconst * w/z
for entrainment, butconst * w
for detrainment. I will do that after this PR.To-do
Content