Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix spatially varying boundary conditions on GPU #2215

Merged
merged 3 commits into from
Oct 16, 2023
Merged

Fix spatially varying boundary conditions on GPU #2215

merged 3 commits into from
Oct 16, 2023

Conversation

simonbyrne
Copy link
Member

Purpose

To-do

Content

  • I have read and checked the items on the review checklist.

@szy21
Copy link
Member

szy21 commented Oct 9, 2023

Try use kappa_4: 1.0e15

@sriharshakandala
Copy link
Member

Can we remove the soft_fail: true flag in the CI pipeline!

@simonbyrne simonbyrne marked this pull request as ready for review October 16, 2023 19:57
charleskawczynski
charleskawczynski reviewed Oct 16, 2023
View reviewed changes
config/gpu_configs/gpu_hs_rhoe_equilmoist_nz63_0M_55km_rs35km.yml
t_end: "300days"
h_elem: 16
dt: "100secs"
t_end: "1days"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest we go at least 10 days, so that the callbacks are exercised.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what callbacks need to be exercised?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default are probably fine, which will probably include a bunch of model-specific pieces (e.g., diagnostics for moisture etc.).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we just reduce the dt_save_to_disk?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay, but that doesn't need to be in the perf target. We should make sure it is in the CI though.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we just reduce the dt_save_to_disk?

Yeah, that works too

@simonbyrne
Copy link
Member Author

Can we remove the soft_fail: true flag in the CI pipeline!

Done

@simonbyrne
Copy link
Member Author

bors r+

bors bot added a commit that referenced this pull request Oct 16, 2023
@bors @simonbyrne
Merge #2215
512c9cc 
2215: Fix spatially varying boundary conditions on GPU r=simonbyrne a=simonbyrne



Co-authored-by: Simon Byrne <simonbyrne@gmail.com>
@bors
Copy link
Contributor

bors bot commented Oct 16, 2023

Build failed:

@simonbyrne
Copy link
Member Author

bors r+

@charleskawczynski charleskawczynski mentioned this pull request Oct 16, 2023
Closed
@bors
Copy link
Contributor

bors bot commented Oct 16, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit f8d6d46 into main Oct 16, 2023
8 checks passed
@bors bors bot deleted the sb/adapt-bc branch October 16, 2023 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charleskawczynski charleskawczynski charleskawczynski left review comments

@sriharshakandala sriharshakandala sriharshakandala approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@simonbyrne @szy21 @sriharshakandala @charleskawczynski