Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set u_3 to 0 at the top cell face #2229

Merged
merged 1 commit into from
Oct 12, 2023
Merged

set u_3 to 0 at the top cell face #2229

merged 1 commit into from
Oct 12, 2023

Conversation

szy21
Copy link
Member

@szy21 szy21 commented Oct 11, 2023 •
edited
Loading

Purpose

Closes #2228
Increases ref contour

To-do

Content

  • I have read and checked the items on the review checklist.

@szy21 szy21 marked this pull request as ready for review October 11, 2023 22:07
@szy21 szy21 requested a review from simonbyrne October 11, 2023 22:07
simonbyrne
simonbyrne approved these changes Oct 11, 2023
View reviewed changes
Copy link
Member

@simonbyrne simonbyrne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine.

@szy21
Copy link
Member Author

szy21 commented Oct 11, 2023

hmm this changes MSE. The results look identical so it's probably just round off errors. @simonbyrne does this make sense?

@szy21
Copy link
Member Author

szy21 commented Oct 12, 2023

bors r+

@bors
Copy link
Contributor

bors bot commented Oct 12, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit dcfb425 into main Oct 12, 2023
8 checks passed
@bors bors bot deleted the zs/set_top_u3 branch October 12, 2023 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonbyrne simonbyrne simonbyrne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set u^3 and u_3 to be zero at the top cell face
2 participants
@szy21 @simonbyrne