add prognostic tke equation for prognostic edmf #2262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szy21
force-pushed
the
zs/add_edmf_tke
branch
4 times, most recently
from
016d165 to
6166ba1
Compare
szy21
force-pushed
the
zs/add_edmf_tke
branch
3 times, most recently
from
36a6179 to
d4979dd
Compare
szy21
commented
Oct 26, 2023
szy21
force-pushed
the
zs/add_edmf_tke
branch
from
d4979dd to
7d30564
Compare
trontrytel
reviewed
Oct 27, 2023
trontrytel
approved these changes
Oct 27, 2023
szy21
force-pushed
the
zs/add_edmf_tke
branch
2 times, most recently
from
b90725e to
ec44aac
Compare
szy21
force-pushed
the
zs/add_edmf_tke
branch
from
ec44aac to
4eadc26
Compare
|
bors r+ |
|
Build failed: |
|
bors r+ |
|
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR adds the prognostic TKE equation for prognostic edmf. It adds two examples with prognostic TKE, GABLS and BOMEX, as we will focus on these two for prognostic edmf test in the near future. GABLS looks ok, which makes me think the equation is probably correct. BOMEX is failing, but I would still like to get this in so it would be easier to test some other closures.
Closes #2248
To-do
Content