Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move temporary variables in cache in p.scratch #2273

Merged
merged 3 commits into from
Oct 25, 2023
Merged

Move temporary variables in cache in p.scratch #2273

merged 3 commits into from
Oct 25, 2023

Conversation

Sbozzolo
Copy link
Member

To be merged after #2270

@Sbozzolo Sbozzolo force-pushed the cache3 branch 6 times, most recently from af6b962 to f50a1d3 Compare October 25, 2023 15:56
@Sbozzolo Sbozzolo marked this pull request as ready for review October 25, 2023 15:57
@Sbozzolo Sbozzolo requested a review from szy21 October 25, 2023 15:57
@Sbozzolo Sbozzolo mentioned this pull request Oct 25, 2023
Merged
szy21
szy21 approved these changes Oct 25, 2023
View reviewed changes
Copy link
Member

@szy21 szy21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There may be some conflicts to be resolved after #2286

@Sbozzolo
Copy link
Member Author

There may be some conflicts to be resolved after #2286

Thanks for pointing that out, I'll wait to bors r+

@Sbozzolo Sbozzolo force-pushed the cache3 branch 2 times, most recently from 0f4ab53 to 5b5739b Compare October 25, 2023 16:51
@Sbozzolo
Copy link
Member Author

bors r+

@bors
Copy link
Contributor

bors bot commented Oct 25, 2023

Canceled.

@Sbozzolo
Copy link
Member Author

bors r+

@bors
Copy link
Contributor

bors bot commented Oct 25, 2023

Merge conflict.

@Sbozzolo Sbozzolo force-pushed the cache3 branch 3 times, most recently from fc84cd9 to 9864101 Compare October 25, 2023 19:49
@Sbozzolo
Copy link
Member Author

bors r+

@bors
Copy link
Contributor

bors bot commented Oct 25, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit 18c84ac into main Oct 25, 2023
8 checks passed
@bors bors bot deleted the cache3 branch October 25, 2023 22:42
@Sbozzolo Sbozzolo mentioned this pull request Oct 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szy21 szy21 szy21 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sbozzolo @szy21