Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase sampling rate for allocations to 1 #2408

Merged
merged 1 commit into from
Dec 4, 2023
Merged

Increase sampling rate for allocations to 1 #2408

merged 1 commit into from
Dec 4, 2023

Conversation

Sbozzolo
Copy link
Member

@Sbozzolo Sbozzolo commented Dec 4, 2023

This provides a full picture of what is happening. It is not much more expensive.

@Sbozzolo
Copy link
Member Author

Sbozzolo commented Dec 4, 2023

https://buildkite.com/clima/climaatmos-ci/builds/15237 for timing information (to see the additional computational cost)

For two jobs the cost is not negligible:

  • barowave jfnk
  • gravity wave

@Sbozzolo
Copy link
Member Author

Sbozzolo commented Dec 4, 2023

https://buildkite.com/clima/climaatmos-ci/builds/15237 for timing information (to see the additional computational cost)

For two jobs the cost is not negligible:

  • barowave jfnk
  • gravity wave

I could reduce the sampling specifically for those two jobs.

@sriharshakandala
Copy link
Member

Would this be memory intensive?

@Sbozzolo Sbozzolo force-pushed the gb/perf_1 branch 2 times, most recently from c2ade20 to 013c8f4 Compare December 4, 2023 19:07
@Sbozzolo
Copy link
Member Author

Sbozzolo commented Dec 4, 2023

Would this be memory intensive?

I am finding that this is prohibitive for jobs that allocate GBs (e.g., gravity waves), so I am trying with scaling the sampling rate with the expected amount of allocations.

perf/flame.jl Outdated Show resolved Hide resolved
@Sbozzolo Sbozzolo enabled auto-merge December 4, 2023 20:13
@Sbozzolo Sbozzolo added this pull request to the merge queue Dec 4, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 4, 2023
@Sbozzolo Sbozzolo added this pull request to the merge queue Dec 4, 2023
Merged via the queue into main with commit 2835c0d Dec 4, 2023
10 checks passed
@Sbozzolo Sbozzolo deleted the gb/perf_1 branch December 4, 2023 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants