-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update long-run builds and add summary of scheduled diagnostics. #2501
Conversation
30f28bc
to
d83aeae
Compare
I only see changes in slab ocean now. Maybe something is wrong with the rebase? |
cbd7757
to
a570a80
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want to change the topography one as well?
We could do so, but I think I'd like to wait for the checks against the WIP implicit update branches and assign parameters accordingly. |
d914730
to
df83bbb
Compare
Build logs from topography longruns (with WIP implicit solver update branch: https://buildkite.com/clima/climaatmos-longruns/builds/1354#018cf69d-e535-4a74-a729-e8e77a617526) |
Could we merge this? |
…nz63_clearsky_tvinsol_0M_slabocean.yml modified: config/longrun_configs/longrun_aquaplanet_rhoe_equil_clearsky_tvinsol_0M_slabocean.yml
6df20e2
to
dba3017
Compare
@Sbozzolo Added the diag print block you suggested in this PR |
I made some minor improvements in 8282e98 At the end, it looks like this: length(diagnostics) > 0 && @info "Computing diagnostics:"
for diag in diagnostics
writer = nameof(typeof(diag.output_writer))
@info "- $(diag.output_short_name) ($writer)"
end It would be great if you could add this instead. If you can keep it as a separate commit in this PR, that would be awesome. (This change will be merged in with #2489 anyway) |
Co-authored-by: Gabriele Bozzola <sbozzolator@gmail.com>
02859a5
to
6b74733
Compare
Follow up PR to #2349.
Uses the new stability dependent diffusion option introduced in PR2349 to the long-run pipeline. (Affects aquaplanet long-run cases)
Updates
type_getters
to summarize + print list of scheduled diagnostics.Diagnostics summary : @Sbozzolo.