Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update long-run builds and add summary of scheduled diagnostics. #2501

Merged
merged 3 commits into from
Jan 12, 2024

Conversation

akshaysridhar
Copy link
Member

@akshaysridhar akshaysridhar commented Jan 9, 2024

Follow up PR to #2349.
Uses the new stability dependent diffusion option introduced in PR2349 to the long-run pipeline. (Affects aquaplanet long-run cases)

Updates type_getters to summarize + print list of scheduled diagnostics.
Diagnostics summary : @Sbozzolo.

@akshaysridhar akshaysridhar self-assigned this Jan 9, 2024
@akshaysridhar akshaysridhar force-pushed the as/frierson-longruns branch 2 times, most recently from 30f28bc to d83aeae Compare January 9, 2024 22:39
@szy21
Copy link
Member

szy21 commented Jan 9, 2024

I only see changes in slab ocean now. Maybe something is wrong with the rebase?

Copy link
Member

@szy21 szy21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to change the topography one as well?

@akshaysridhar
Copy link
Member Author

Do you want to change the topography one as well?

We could do so, but I think I'd like to wait for the checks against the WIP implicit update branches and assign parameters accordingly.

@akshaysridhar
Copy link
Member Author

akshaysridhar commented Jan 11, 2024

Build logs from topography longruns (with WIP implicit solver update branch: https://buildkite.com/clima/climaatmos-longruns/builds/1354#018cf69d-e535-4a74-a729-e8e77a617526)

@szy21
Copy link
Member

szy21 commented Jan 11, 2024

Could we merge this?

…nz63_clearsky_tvinsol_0M_slabocean.yml

	modified:   config/longrun_configs/longrun_aquaplanet_rhoe_equil_clearsky_tvinsol_0M_slabocean.yml
@akshaysridhar
Copy link
Member Author

@Sbozzolo Added the diag print block you suggested in this PR type_getters.jl. If this is reasonable I can queue this to be merged soon.

@akshaysridhar akshaysridhar changed the title Update long-run builds to use Frierson diffusion option. Update long-run builds and add summary of scheduled diagnostics. Jan 11, 2024
@Sbozzolo
Copy link
Member

Sbozzolo commented Jan 11, 2024

@Sbozzolo Added the diag print block you suggested in this PR type_getters.jl. If this is reasonable I can queue this to be merged soon.

I made some minor improvements in 8282e98

At the end, it looks like this:

    length(diagnostics) > 0 && @info "Computing diagnostics:"

    for diag in diagnostics
        writer = nameof(typeof(diag.output_writer))
        @info "- $(diag.output_short_name) ($writer)"
    end

It would be great if you could add this instead. If you can keep it as a separate commit in this PR, that would be awesome.

(This change will be merged in with #2489 anyway)

akshaysridhar and others added 2 commits January 11, 2024 14:50
Co-authored-by: Gabriele Bozzola <sbozzolator@gmail.com>
@akshaysridhar akshaysridhar force-pushed the as/frierson-longruns branch 2 times, most recently from 02859a5 to 6b74733 Compare January 11, 2024 22:55
@akshaysridhar akshaysridhar added this pull request to the merge queue Jan 11, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 12, 2024
@akshaysridhar akshaysridhar added this pull request to the merge queue Jan 12, 2024
Merged via the queue into main with commit 7b5184e Jan 12, 2024
13 checks passed
@akshaysridhar akshaysridhar deleted the as/frierson-longruns branch January 12, 2024 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants