Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Interface tests: ClimaAtmos spaces, callbacks and parameterized tendency construction #2771

Merged
merged 1 commit into from
Apr 8, 2024
Merged

Interface tests: ClimaAtmos spaces, callbacks and parameterized tendency construction #2771

merged 1 commit into from
Apr 8, 2024

Conversation

akshaysridhar
Copy link
Member

@akshaysridhar akshaysridhar commented Mar 8, 2024 •
edited
Loading

Adds tests for ClimaAtmos space construction, rrtmgp interfaces, callbacks, topography (and some parameterized tendencies).

@akshaysridhar akshaysridhar force-pushed the as/spaces-test branch 8 times, most recently from a5e5f7b to 83fbadb Compare March 12, 2024 22:07
@akshaysridhar akshaysridhar marked this pull request as ready for review March 13, 2024 20:37
@akshaysridhar akshaysridhar force-pushed the as/spaces-test branch 3 times, most recently from 5e9aa14 to aba9022 Compare March 15, 2024 16:31
@sriharshakandala
Copy link
Member

Can we add a quick summary for each of the tests!

@akshaysridhar akshaysridhar force-pushed the as/spaces-test branch 8 times, most recently from 0806b61 to 25bb105 Compare March 21, 2024 20:40
@akshaysridhar akshaysridhar force-pushed the as/spaces-test branch 4 times, most recently from fbac959 to 1ac039e Compare April 4, 2024 16:07
@akshaysridhar akshaysridhar requested a review from Sbozzolo April 4, 2024 16:14
@akshaysridhar akshaysridhar changed the title Interface tests: ClimaAtmos spaces and callback construction Interface tests: ClimaAtmos spaces, callbacks and parameterized tendency construction Apr 4, 2024
@akshaysridhar akshaysridhar force-pushed the as/spaces-test branch 4 times, most recently from 0c75b08 to 5172da1 Compare April 4, 2024 17:29
@akshaysridhar
Copy link
Member Author

The gpu flame job is flaky here :(

Sbozzolo
Sbozzolo reviewed Apr 5, 2024
View reviewed changes
Copy link
Member

@Sbozzolo Sbozzolo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add job that runs the tests on GPU in buildkite, please?

test/callbacks.jl Show resolved Hide resolved
test/test_helpers.jl Outdated Show resolved Hide resolved
test/test_helpers.jl Show resolved Hide resolved
test/topography.jl Outdated Show resolved Hide resolved
test/solver/model_getters.jl Show resolved Hide resolved
test/parameterized_tendencies/sponge/rayleigh_sponge.jl Outdated Show resolved Hide resolved
@akshaysridhar
Reorganise tests, mirror src directory structure, add helper functions,
ab3dddc 
add interface checks for RRTMGPInterface, simple tests for CM, hybrid
spaces, sponges, topography
@akshaysridhar akshaysridhar added this pull request to the merge queue Apr 8, 2024
Merged via the queue into main with commit d8dd580 Apr 8, 2024
11 checks passed
@akshaysridhar akshaysridhar deleted the as/spaces-test branch April 8, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sbozzolo Sbozzolo Sbozzolo left review comments

@sriharshakandala sriharshakandala Awaiting requested review from sriharshakandala

Assignees
No one assigned
Labels
Quality assurance Tests
Projects
None yet
Milestone
O1.2.3 Add unit tests to ClimaAtmos
Development

Successfully merging this pull request may close these issues.
3 participants
@akshaysridhar @sriharshakandala @Sbozzolo