Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Widen gpu allocations buffer #2878

Merged
merged 1 commit into from
Apr 6, 2024
Merged

Widen gpu allocations buffer #2878

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions perf/flame.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,8 +88,10 @@ using Test
# Threaded/gpu allocations are not deterministic, so let's add a buffer
# TODO: remove buffer, and threaded tests, when
# threaded/unthreaded functions are unified
buffer = if any(x -> occursin(x, job_id), ("threaded", "gpu"))
buffer = if any(x -> occursin(x, job_id), ("threaded",))
1.8
elseif any(x -> occursin(x, job_id), ("gpu",))
5
else
1.1
end
Expand All @@ -108,9 +110,13 @@ end

# https://github.com/CliMA/ClimaAtmos.jl/issues/827
@testset "Allocations limit" begin
@test 0.5 * allocs_limit[job_id] * buffer <=
allocs ≤
allocs_limit[job_id] * buffer
if occursin("gpu", job_id) # https://github.com/CliMA/ClimaAtmos.jl/issues/2831
@test allocs ≤ allocs_limit[job_id] * buffer
else
@test 0.25 * allocs_limit[job_id] * buffer <=
allocs ≤
allocs_limit[job_id] * buffer
end
end

import ClimaComms
Expand Down
Loading