Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old code (coupler compatibility) #2885

Closed
wants to merge 1 commit into from
Closed

Conversation

akshaysridhar
Copy link
Member

Remove unused lines.
cc @LenkaNovak @szy21

	modified:   src/surface_conditions/surface_conditions.jl
@akshaysridhar akshaysridhar marked this pull request as ready for review April 8, 2024 15:02
@szy21
Copy link
Member

szy21 commented Apr 8, 2024

This was needed to run diagnostic edmf in the coupler. Do we not need it anymore?

@akshaysridhar
Copy link
Member Author

This was needed to run diagnostic edmf in the coupler. Do we not need it anymore?

Yeah I see that now - I wanted to test this by removing the old block (and it's clear from the ci outputs that we still need it). I'll start an issue to track that and close this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants