Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rm code dup, rm some prints, tabulate scaling #2892

Merged
merged 2 commits into from
Apr 9, 2024
Merged

Rm code dup, rm some prints, tabulate scaling #2892

merged 2 commits into from
Apr 9, 2024

Conversation

charleskawczynski
Copy link
Member

This PR

  • Removes some @show calls that I didn't intend to leave
  • Tabulates some of the scaling results
  • Removes some code duplication in the scaling results

nefrathenrici
nefrathenrici approved these changes Apr 9, 2024
View reviewed changes
Copy link
Member

@nefrathenrici nefrathenrici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tables are great for exact numbers!

The only change is the artifact paths for the plotting jobs, they should not have output_active in the path since these jobs don't use OutputPathGenerator

@charleskawczynski
Copy link
Member Author

The tables are great for exact numbers!
Agreed-- very copy-paste friendly, too.

The only change is the artifact paths for the plotting jobs, they should not have output_active in the path since these jobs don't use OutputPathGenerator

Ah, great point. Thank you!

@charleskawczynski charleskawczynski merged commit e7221ba into main Apr 9, 2024
7 of 8 checks passed
@charleskawczynski charleskawczynski deleted the ck/scaling_plot_utils branch April 9, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nefrathenrici nefrathenrici nefrathenrici approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@charleskawczynski @nefrathenrici