add vertical fluctuation and nudging for GCM driven SCM #2903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szy21
force-pushed
the
zs/cc/les_driven_scm
branch
5 times, most recently
from
c80382b to
b7d9443
Compare
szy21
changed the title
szy21
force-pushed
the
zs/cc/les_driven_scm
branch
6 times, most recently
from
6d68d5b to
78e8426
Compare
szy21
force-pushed
the
zs/cc/les_driven_scm
branch
from
78e8426 to
de637e8
Compare
szy21
requested review from
trontrytel,
charleskawczynski,
costachris and
haakon-e
szy21
force-pushed
the
zs/cc/les_driven_scm
branch
from
de637e8 to
6a9a03d
Compare
szy21
commented
Apr 15, 2024
Comment on lines
+24
to
+26
| hr = 3600 | ||
| ᶜτ_scalar = 24hr | ||
| ᶜτ_wind = 6hr |
There was a problem hiding this comment.
Maybe use a coefficient rather than timescale so that we can have 0 relaxation for scalar or wind separately (by setting the coefficient to 0) without an additional flag.
szy21
force-pushed
the
zs/cc/les_driven_scm
branch
from
6a9a03d to
39b36c0
Compare
charleskawczynski
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
co-authored-by: @costachris @haakon-e
Adds infrastructure for vertical fluctuation and nudging tendency for GCM driven SCM. I hope after this PR we can parallelize the work with:
Part of #2901
To-do
Content