Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove unnecessary CoupledSimulation fields #1015

Closed
Tracked by #1050
juliasloan25 opened this issue Oct 12, 2024 · 1 comment · Fixed by #1061
Closed
Tracked by #1050

remove unnecessary CoupledSimulation fields #1015

juliasloan25 opened this issue Oct 12, 2024 · 1 comment · Fixed by #1061
Assignees
@juliasloan25
Labels
💰 Grab Bag
Milestone
Maintenance and I...

Comments

@juliasloan25
Copy link
Member

juliasloan25 commented Oct 12, 2024 •
edited
Loading

We store t in our CoupledSimulation object, but never update or use it. We should remove this field, and go through CoupledSimulation to find all its fields that are unused or can be removed.

CoupledSimulation is meant to hold all the information needed to solve the simulation, but it shouldn't contain anything extra (e.g. values used for initialization or unused objects)

Fields to remove

  • t
  • parsed_args
@juliasloan25 juliasloan25 mentioned this issue Nov 1, 2024
Open
@juliasloan25 juliasloan25 self-assigned this Nov 4, 2024
This was referenced Nov 5, 2024
Open
Merged
@juliasloan25
Copy link
Member Author

There are a couple more fields that can almost be removed - these will be addressed in #1060

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@juliasloan25 juliasloan25

Labels
💰 Grab Bag
Projects
None yet
Milestone
Maintenance and Improvements
Development

Successfully merging a pull request may close this issue.

remove t and parsed_args from CoupledSimulation CliMA/ClimaCoupler.jl
1 participant
@juliasloan25