Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace OrdinaryDiffEq dep with SciMLBase #427

Closed
Tracked by #358
juliasloan25 opened this issue Sep 18, 2023 · 1 comment
Closed
Tracked by #358

Replace OrdinaryDiffEq dep with SciMLBase #427

juliasloan25 opened this issue Sep 18, 2023 · 1 comment
Assignees
Labels
🍃 leaf Issue coupled to a PR

Comments

@juliasloan25
Copy link
Member

juliasloan25 commented Sep 18, 2023

Recently, OrdinaryDiffEq usage was replaced by SciMLBase and DiffEqCallbacks in ClimaLSM. This greatly decreased precompilation time, cutting CI times by nearly half. I think we can do the same in the coupler.

This as also attempted in ClimaAtmos, but they weren't able to completely remove ODE as a dependency because they use some algorithms and types defined in ODE but not in SciMLBase (see PR there for details). I don't think we'll run into that issue here.

Update: As of 25 October, ClimaAtmos has removed their ODE.jl dependency, so it will be worth it for us to re-attempt this

@juliasloan25
Copy link
Member Author

closed by #526

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍃 leaf Issue coupled to a PR
Projects
None yet
Development

No branches or pull requests

1 participant