Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spatially varying biogeochemistry #671

Closed
kmdeck opened this issue Jun 21, 2024 · 0 comments · Fixed by #690
Closed

Spatially varying biogeochemistry #671

kmdeck opened this issue Jun 21, 2024 · 0 comments · Fixed by #690
Assignees
Labels
enhancement New feature or request

Comments

@kmdeck
Copy link
Member

kmdeck commented Jun 21, 2024

Is your feature request related to a problem? Please describe.
The soil biogeochemistry model does not support spatially varying parameters. That means that we currently have a mismatch in soil porosity between biogeochemistry and the full soil model in global runs.
#591

Describe the solution you'd like
Spatially varyin biogeochemistry parameters consistent with the soil. To do this, store porosity, theta_100, and b inside the PrognosticMet struct. either pass directly, or compute from van genuchten

@kmdeck kmdeck added the enhancement New feature or request label Jun 21, 2024
@kmdeck kmdeck mentioned this issue Jul 2, 2024
36 tasks
@kmdeck kmdeck self-assigned this Jul 5, 2024
@kmdeck kmdeck added this to the O2.3.5 Global run on GPU milestone Jul 5, 2024
@kmdeck kmdeck linked a pull request Jul 5, 2024 that will close this issue
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant