Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move albedo, surface roughness lengths, etc out of EnergyHydrologyParameters and into BC struct #885

Open
kmdeck opened this issue Oct 24, 2024 · 0 comments
Open

Move albedo, surface roughness lengths, etc out of EnergyHydrologyParameters and into BC struct #885

kmdeck opened this issue Oct 24, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@kmdeck
Copy link
Member

kmdeck commented Oct 24, 2024

Is your feature request related to a problem? Please describe.
Currently, the soil albedo, roughness lengths, and other? parameters that are only needed when we choose a AtmosDrivenFluxBC are required in all EnergyHydrology runs. We have defaults set to mitigate this, but it would be cleaner to move these parameters out of EnergyHydrologyParameters (needed for all EH models), and into the AtmosDrivenFluxBC itself.

We should also consider package the albedo parameters into a struct.

See #828 #862
@kmdeck kmdeck added the enhancement New feature or request label Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kmdeck