Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Plots.jl dependency #927

Closed
juliasloan25 opened this issue Nov 18, 2024 · 2 comments
Closed

Remove Plots.jl dependency #927

juliasloan25 opened this issue Nov 18, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@juliasloan25
Copy link
Member

Is your feature request related to a problem? Please describe.
Our codebase currently uses both Makie.jl and Plots.jl. It would be good to converge to using only Makie.jl and remove the extra Plots.jl dependency, to decrease our overall number of dependencies and decrease precompilation time.

This will also decrease precompilation time downstream in ClimaCoupler.jl once we remove the Plots.jl dependency there.

@imreddyTeja
Copy link
Contributor

Plots.jl is not a dependency of the ClimaLand package. All of the instances of Plots.jl usage are in the docs or experiments, so I don't think this will decrease pre-compilation time in ClimaCoupler.

@juliasloan25
Copy link
Member Author

Plots.jl is not a dependency of the ClimaLand package. All of the instances of Plots.jl usage are in the docs or experiments, so I don't think this will decrease pre-compilation time in ClimaCoupler.

In this issue I meant to remove it from where it's used in docs and experiments, which was done in CliMA/ClimaCoupler.jl#1097. This is also a duplicate of CliMA/ClimaCoupler.jl#1091 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants