CompatHelper: bump compat for Thermodynamics to 0.11, (keep existing compat) #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
bors bot
added a commit
that referenced
this pull request
Sep 7, 2023
314: Remove overloaded getindex r=kmdeck a=charleskawczynski This PR removes the overloading of `getindex` on ClimaCore fields. also closes #317 #312 We access the individual fields within the Field of Tuples using the following rules: Previously, regardless of in a loop or not: ``` field[i] .= .... `@.` field[i] = g(other field) ``` Now: outside of a loop: ``` field.:i .= ... ``` Now: inside of a loop: ``` field.:($i) .= `@.` field.:($$i) = ``` We also need to sometimes access elements that are compute quantities, for example, before, ``` field[n_stem+n_leaf] .= ``` Now, we need to do something like: ``` i_end =n_stem+n_leaf # define intermediate quantity field.:($i_end) .= ``` regardless of if we are in a loop or not. Co-authored-by: Charles Kawczynski <kawczynski.charles@gmail.com>
|
closed by #277 |
mitraA90
pushed a commit
that referenced
this pull request
Dec 22, 2023
314: Remove overloaded getindex r=kmdeck a=charleskawczynski This PR removes the overloading of `getindex` on ClimaCore fields. also closes #317 #312 We access the individual fields within the Field of Tuples using the following rules: Previously, regardless of in a loop or not: ``` field[i] .= .... `@.` field[i] = g(other field) ``` Now: outside of a loop: ``` field.:i .= ... ``` Now: inside of a loop: ``` field.:($i) .= `@.` field.:($$i) = ``` We also need to sometimes access elements that are compute quantities, for example, before, ``` field[n_stem+n_leaf] .= ``` Now, we need to do something like: ``` i_end =n_stem+n_leaf # define intermediate quantity field.:($i_end) .= ``` regardless of if we are in a loop or not. Co-authored-by: Charles Kawczynski <kawczynski.charles@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request changes the compat entry for the
Thermodynamicspackage from0.9, 0.10to0.9, 0.10, 0.11.This keeps the compat entries for earlier versions.
Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.