Turn off dss #650
Turn off dss #650
Conversation
| @@ -11,6 +11,7 @@ import ClimaLand | |||
| import ClimaLand.Parameters as LP | |||
|
|
|||
| for FT in (Float32, Float64) | |||
| #= | |||
There was a problem hiding this comment.
commented out these tests since they compare the output of exp_tendency! with an analytic expression, but exp_tendency! does not do anything if there is no lateral flow.
| #for key in propertynames(Y) | ||
| # property = getproperty(Y, key) | ||
| # dss_helper!(property, axes(property), p) | ||
| #end |
There was a problem hiding this comment.
Do we want to remove this, or just comment it out?
There was a problem hiding this comment.
I think just comment it out, since we want to come back to lateral flow at some point...and maybe if this PR causes issues, we want to be able to turn it back on? but also this stuff is preserved in git history.
|
@Sbozzolo Im not sure if this is "grid imprinting" or just coarse resolution images. Either way, I think this is ready to merge after rebasing, unless we want to try a very long coupler run using this clima land branch? I had already triggered a regular Coupler long run and Zhaoyi thought it looked fine. |
experiments/Manifest.toml
Outdated
There was a problem hiding this comment.
I think this Manifest should not be included
Remove experiment Manifest.toml and update README
Purpose
Turn off dss, but preserve the capabilities/code for future use
-> turn off lateral flow
-> comment out some tests of horizontal tendencies in soil
Plots for the global bucket run without DSS - we see some grid imprinting
These are made with CC Makie:
