Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade to use ClimaUtilities 1.10 #693

Merged
merged 1 commit into from
Jul 11, 2024
Merged

upgrade to use ClimaUtilities 1.10 #693

merged 1 commit into from
Jul 11, 2024

Conversation

kmdeck
Copy link
Member

@kmdeck kmdeck commented Jul 10, 2024 •
edited
Loading

Purpose

  • Minor upgrade to Manifest.toml
  • Make sure we instantiate the main project prior to buildkite environment in the target pipeline. Previously, we were not doing this, and somehow then not using the correct packages. Note that our regular buildkite pipeline does this already and works fine.

To-do

Content

  • I have read and checked the items on the review checklist.

@kmdeck kmdeck added the Run benchmarks Add this label to run benchmarks on clima label Jul 10, 2024
@kmdeck kmdeck force-pushed the kd/upgrade_packages branch from 1be85a7 to 4ea6be0 Compare July 11, 2024 17:57
@kmdeck kmdeck marked this pull request as ready for review July 11, 2024 18:06
@kmdeck kmdeck requested a review from szy21 July 11, 2024 18:07
@kmdeck kmdeck enabled auto-merge July 11, 2024 18:24
@kmdeck kmdeck added the bug Something isn't working label Jul 11, 2024
@kmdeck kmdeck merged commit 72f4b98 into main Jul 11, 2024
10 of 11 checks passed
@kmdeck kmdeck deleted the kd/upgrade_packages branch July 11, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szy21 szy21 szy21 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working Run benchmarks Add this label to run benchmarks on clima
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kmdeck @szy21