Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove two not-needed functions #697

Merged
merged 1 commit into from
Jul 16, 2024
Merged

remove two not-needed functions #697

merged 1 commit into from
Jul 16, 2024

Conversation

kmdeck
Copy link
Member

@kmdeck kmdeck commented Jul 15, 2024

Purpose

These functions are not needed because (1) they are extremely simply (just returning something) and (2) we do not have multiple methods and do not have a need to specialize.

To-do

Content

Remove ClimaLand.liquid_precipitation and ClimaLand.snow_precipitation.

Review checklist

I have:

In the Content, I have included

  • relevant unit tests, and integration tests,
  • appropriate docstrings on all functions, structs, and modules, and included relevant documentation.

  • I have read and checked the items on the review checklist.

@kmdeck kmdeck requested a review from akshaysridhar July 15, 2024 17:39
@kmdeck kmdeck self-assigned this Jul 15, 2024
@kmdeck kmdeck added the software clarity PRs that maintain functionality but increase clarity of code label Jul 15, 2024
@kmdeck kmdeck force-pushed the kd/quick_driver_cleanup branch from 8c72ab4 to 0574357 Compare July 15, 2024 18:26
@kmdeck kmdeck marked this pull request as ready for review July 15, 2024 18:28
Copy link
Member

@akshaysridhar akshaysridhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we can merge it once it's rebased.

@kmdeck kmdeck force-pushed the kd/quick_driver_cleanup branch from 0574357 to bd01e9b Compare July 16, 2024 17:05
@kmdeck kmdeck enabled auto-merge July 16, 2024 18:01
@kmdeck kmdeck merged commit 47af041 into main Jul 16, 2024
9 of 10 checks passed
@kmdeck kmdeck deleted the kd/quick_driver_cleanup branch October 10, 2024 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
software clarity PRs that maintain functionality but increase clarity of code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants