Increasing phase change timescale for soil #703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmdeck
force-pushed
the
kd/soil_freeze_thaw_timestepping_improvements
branch
from
39b57cf to
072645c
Compare
kmdeck
force-pushed
the
kd/soil_freeze_thaw_timestepping_improvements
branch
2 times, most recently
from
4ba3370 to
b47ce10
Compare
kmdeck
force-pushed
the
kd/soil_freeze_thaw_timestepping_improvements
branch
from
9e5539d to
f5eb790
Compare
AlexisRenchon
approved these changes
Sep 12, 2024
juliasloan25
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The phase change term is a relaxation term which requires a timescale. Our current code uses the thermal timescale of the first layer, i.e. dz_top^2*specific_heat/conductivity. This modifies the timescale to be the thermal time per layer, which requires dz of each layer. These are different since the layers are smaller near the top of the domain.
To-do
Review
Content
Add dz to domain.fields
Use in phase change computation