-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New evaporation scheme #732
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the big PR! It looks great!
I bring two things up in this review:
- do we need to add
vapor_flux_ice
to diagnostics in this PR? - going through this, I realized that it would be helpful to make a table in the docs containing as many acronyms as we can, with additional info ("stands for", "units", "comment"), somewhat akin to the diagnostics table, but with all sort of acronyms that we use throughout ClimaLand code. This table would probably be huge but very useful, and users would find what they look for via ctrl+f. Examples: Y, p, t, θ_i_sfc, z_0m, ts_in, etc. etc. We could refer to this table in many places.
(obviously this should be in another PR)
@@ -136,7 +136,7 @@ end | |||
@diagnostic_compute "soil_aerodynamic_resistance" SoilCanopyModel p.soil.turbulent_fluxes.r_ae | |||
@diagnostic_compute "soil_latent_heat_flux" SoilCanopyModel p.soil.turbulent_fluxes.lhf | |||
@diagnostic_compute "soil_sensible_heat_flux" SoilCanopyModel p.soil.turbulent_fluxes.shf | |||
@diagnostic_compute "vapor_flux" SoilCanopyModel p.soil.turbulent_fluxes.vapor_flux | |||
@diagnostic_compute "vapor_flux" SoilCanopyModel p.soil.turbulent_fluxes.vapor_flux_liq # should add ice here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You mean add vapor_flux_ice
?
But it currently doesn't exist?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, in this PR we added it. eventually it would be nice to have sublimation as a diagnostic also, and I could add it in this PR?
d5352bb
to
9e72938
Compare
2d318c4
to
8afd855
Compare
For benchmarking - this PR:
Previous main:
I think this is not surprising given that we now call surface fluxes 2x per step for the soil model, rather than 1x. |
a192884
to
accec84
Compare
Purpose
Large changes to src/standalone/Soil/energy_hydrology.jl, all else is updating scripts and tests
To-do
Content
Changes evaporation scheme by writing a new
turbulent_fluxes
method for EnergyHydrology.Computes ice and liquid water fluxes separately, so ice_frac is no longer needed, and we now compute vapor_flux_ice
and vapor_flux_liq and store them separately.
Remove/comment out code from previous scheme (surface_resistance, dry_soil_thickness, tortuosity etc functions)
Update scripts/tests