Refactor to use diagnostics throughout #746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We can add an ArrayWriter too. It would probably make single site much simpler. |
AlexisRenchon
force-pushed
the
ar/refactor_with_diagnostics
branch
2 times, most recently
from
2ae3e38 to
59f93c6
Compare
AlexisRenchon
force-pushed
the
ar/refactor_with_diagnostics
branch
10 times, most recently
from
4ad6766 to
70dcc38
Compare
Closed
AlexisRenchon
force-pushed
the
ar/refactor_with_diagnostics
branch
6 times, most recently
from
0ae017a to
f9999b3
Compare
Sbozzolo
reviewed
Oct 15, 2024
Comment on lines
336
to
339
| SIF, AR, g_stomata, GPP, canopy_T, SW_u, LW_u, ER, ET, β, SHF, LHF, G, Rn = [ | ||
| ClimaLand.Diagnostics.diagnostic_as_vectors(d_writer, diag_name, 1)[2][1:721] | ||
| for diag_name in hourly_diag_name | ||
| ] # [1:721] only because summer subset of model output |
There was a problem hiding this comment.
This doesn't scale very well. ClimaLand.Diagnostics.diagnostic_as_vectors returns the time too, can you use that to detect when it is summer instead?
There was a problem hiding this comment.
I agree that this old script had many hardcoded stuff that make it difficult to maintain, and should be refactored properly.
however for instance, we were doing summer only because there was no snow model. once we have snow, we will run the whole year/dataset. so this is temporary.
AlexisRenchon
force-pushed
the
ar/refactor_with_diagnostics
branch
3 times, most recently
from
042ecc6 to
b57f2be
Compare
Sbozzolo
reviewed
Oct 15, 2024
Sbozzolo
reviewed
Oct 15, 2024
Sbozzolo
reviewed
Oct 15, 2024
AlexisRenchon
force-pushed
the
ar/refactor_with_diagnostics
branch
7 times, most recently
from
58015a5 to
ee3f7d0
Compare
AlexisRenchon
force-pushed
the
ar/refactor_with_diagnostics
branch
2 times, most recently
from
b43b42a to
c8ac585
Compare
- diagnostics were added for net radiation, latent heat flux, sensible heat flux, and ground heat flux. - the function `diagnostic_as_vectors` was added, to get vector outputs from DictWriter. - water runoff was added to `run_fluxnet`. - `run_fluxnet` now uses diagnostics.
AlexisRenchon
force-pushed
the
ar/refactor_with_diagnostics
branch
from
c8ac585 to
2d7c375
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
diagnostics_as_vectorfunction, to get diagnostics from DictWritersrun_fluxnetcloses #788