Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use ClimaArtifacts Lehmann 2008 evaporation artifact #929

Merged
merged 1 commit into from
Nov 23, 2024
Merged

Conversation

juliasloan25
Copy link
Member

Purpose

Use Lehmann et al 2008 evaporation dataset, added to ClimaArtifacts in CliMA/ClimaArtifacts#82

To-do

Content


  • I have read and checked the items on the review checklist.


Local path to file containing measured evaporation rate as a function of time
Returns the path to file containing measured evaporation rate as a function of time
for bare soil.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can mention here that it refers to Figure 8 of the paper.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Further down in the docstring it says "Data was originally collected by ... and presented
in Figure 8 of that work."

Copy link
Member

@kmdeck kmdeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you! Looks good

@juliasloan25 juliasloan25 merged commit 5462eef into main Nov 23, 2024
16 checks passed
@juliasloan25 juliasloan25 deleted the js/evap branch November 23, 2024 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants