Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

long run without eneryg flux due to water #950

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 0 additions & 30 deletions .buildkite/longruns_gpu/pipeline.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,26 +41,6 @@ steps:
env:
CLIMACOMMS_DEVICE: "CUDA"

- label: ":seedling: Soil-Canopy"
command:
- julia --color=yes --project=.buildkite experiments/long_runs/land.jl
artifact_paths: "land_longrun_gpu/*pdf"
agents:
slurm_gpus: 1
slurm_time: 15:00:00
env:
CLIMACOMMS_DEVICE: "CUDA"

- label: ":sunglasses: California regional simulation"
command:
- julia --color=yes --project=.buildkite experiments/long_runs/land_region.jl
artifact_paths: "california_longrun_gpu/*pdf"
agents:
slurm_gpus: 1
slurm_time: 00:30:00
env:
CLIMACOMMS_DEVICE: "CUDA"

- label: "Soil"
command:
- julia --color=yes --project=.buildkite experiments/long_runs/soil.jl
Expand All @@ -70,13 +50,3 @@ steps:
slurm_time: 15:00:00
env:
CLIMACOMMS_DEVICE: "CUDA"

- label: "Global bucket simulation"
command:
- julia --color=yes --project=.buildkite experiments/long_runs/bucket.jl
artifact_paths: "bucket_longrun_gpu/*pdf"
agents:
slurm_gpus: 1
slurm_time: 00:30:00
env:
CLIMACOMMS_DEVICE: "CUDA"
2 changes: 1 addition & 1 deletion experiments/long_runs/snowy_land.jl
Original file line number Diff line number Diff line change
Expand Up @@ -402,7 +402,7 @@ function setup_and_solve_problem(; greet = false)

t0 = 0.0
tf = 60 * 60.0 * 24 * 365 * 2
Δt = 450.0
Δt = 900.0
nelements = (101, 15)
if greet
@info "Run: Global Soil-Canopy-Snow Model"
Expand Down
4 changes: 2 additions & 2 deletions experiments/long_runs/soil.jl
Original file line number Diff line number Diff line change
Expand Up @@ -220,8 +220,8 @@ end
function setup_and_solve_problem(; greet = false)

t0 = 0.0
tf = 60 * 60.0 * 24 * 365
Δt = 450.0
tf = 60 * 60.0 * 24 * 365 * 2
Δt = 900.0
nelements = (101, 15)
if greet
@info "Run: Global Soil Model"
Expand Down
14 changes: 7 additions & 7 deletions src/standalone/Soil/energy_hydrology.jl
Original file line number Diff line number Diff line change
Expand Up @@ -275,13 +275,13 @@ function ClimaLand.make_compute_imp_tendency(
# GradC2F returns a Covariant3Vector, so no need to convert.
@. dY.soil.ρe_int =
-divf2c_heat(
-interpc2f(p.soil.κ) * gradc2f(p.soil.T) -
interpc2f(
volumetric_internal_energy_liq(
p.soil.T,
model.parameters.earth_param_set,
) * p.soil.K,
) * gradc2f(p.soil.ψ + z),
-interpc2f(p.soil.κ) * gradc2f(p.soil.T),# -
# interpc2f(
# volumetric_internal_energy_liq(
# p.soil.T,
# model.parameters.earth_param_set,
# ) * p.soil.K,
# ) * gradc2f(p.soil.ψ + z),
)

# Don't update the prognostic variables we're stepping explicitly
Expand Down
Loading