Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extensive component tests needed #63

Open
mcgibbon opened this issue Jul 12, 2018 · 2 comments
Open

Extensive component tests needed #63

mcgibbon opened this issue Jul 12, 2018 · 2 comments

Comments

@mcgibbon
Copy link
Member

mcgibbon commented Jul 12, 2018

There are a lot of edge cases we currently don't test on CliMT components. We should create unit tests for as many of these as we can think of. Some examples:

GFS:

  • With or without contained Prognostic objects
  • When contained Prognostic objects have different output dims than itself
  • When passed Prognostics attempt to diagnostically output quantities that GFS steps (like air temperature)
  • When passed Prognostics step quantities GFS steps, and when they step quantities GFS does not step
  • When multiple passed Prognostics compute tendencies for the same quantity
  • In moist mode and dry mode
  • With different numbers of vertical levels

I'll work on making these after the Sympl 0.4.0 updates. I may continue using this issue as a pad for examples of needed unit tests. Feel free to add any you think of, if you'd like.

@mcgibbon
Copy link
Member Author

Some of these have been implemented in #68, but not all of them.

@mcgibbon
Copy link
Member Author

Still need to go through every component and think about what options should be enabled/disabled for tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant