Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessary Setting added #372

Open
Shlomixg opened this issue Oct 28, 2024 · 2 comments
Open

Unnecessary Setting added #372

Shlomixg opened this issue Oct 28, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@Shlomixg
Copy link
Contributor

Describe the bug

An unnecessary setting replicated_deduplication_window=0 is added to all tables created using DBT:

{{
    config(
        materialized = 'table',
        schema = 'default_schema'
    )
}}

select 1

and result is:

-- default_schema.test_table definition

CREATE TABLE default_schema.test_table
(
    `1` UInt8
)
ENGINE = MergeTree
ORDER BY tuple()
SETTINGS replicated_deduplication_window = 0,
 index_granularity = 8192;

How can I disable it?

Expected behaviour

Create the tables without the setting

dbt and/or ClickHouse server logs

/* {"app": "dbt", "dbt_version": "1.8.8", "profile_name": "default_schema", "target_name": "default_schema", "node_id": "model.ra_dbt.test_table"} */
create table `datricks`.`test_table`
engine = MergeTree()
 order by (tuple())
-- end_of_sql
SETTINGS  replicated_deduplication_window=0
empty
as (
select 1
)

Configuration

Environment

  • dbt version: 1.8.8
  • dbt-clickhouse version: 1.8.4
  • clickhouse-driver version: 0.2.9
  • Python version: 3.11.9
  • Operating system: Debian 12 (on docker)
  • We are not using Clickhouse Keeper\ZooKeeper or any distributed DDL
@Shlomixg Shlomixg added the bug Something isn't working label Oct 28, 2024
@genzgd
Copy link
Contributor

genzgd commented Oct 28, 2024

It is necessary in some cases to prevent duplicates. Why do you need to disable it?

@Shlomixg
Copy link
Contributor Author

Shlomixg commented Oct 28, 2024

According to the docs this setting is relevant only to replicated tables on ClickHouse Keeper, which we are not using.
I don't want to disable it, just think it's not necessary to add it to each table

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants