Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap columns_in_query query in select statement #222

Merged
merged 2 commits into from
Dec 13, 2023
Merged

Wrap columns_in_query query in select statement #222

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
99de430
Wrap columns_in_query query in select statement
ptemarvelde Dec 13, 2023
3c0e3ab
formatting
ptemarvelde Dec 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dbt/adapters/clickhouse/httpclient.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ def command(self, sql, **kwargs):

def columns_in_query(self, sql: str, **kwargs) -> List[ClickHouseColumn]:
try:
query_result = self._client.query(f'{sql} LIMIT 0', **kwargs)
query_result = self._client.query(f"SELECT * FROM ({sql}) LIMIT 0", **kwargs)
return [
ClickHouseColumn.create(name, ch_type.name)
for name, ch_type in zip(query_result.column_names, query_result.column_types)
Expand Down
4 changes: 3 additions & 1 deletion dbt/adapters/clickhouse/nativeclient.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,9 @@ def command(self, sql, **kwargs):

def columns_in_query(self, sql: str, **kwargs) -> List[ClickHouseColumn]:
try:
_, columns = self._client.execute(f'{sql} LIMIT 0', with_column_types=True)
_, columns = self._client.execute(
f"SELECT * FROM ({sql}) LIMIT 0", with_column_types=True
)
return [ClickHouseColumn.create(column[0], column[1]) for column in columns]
except clickhouse_driver.errors.Error as ex:
raise DbtDatabaseError(str(ex).strip()) from ex
Expand Down