Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor network_x_processor #341

Open
1 task
danmash opened this issue Jun 21, 2022 · 0 comments
Open
1 task

Refactor network_x_processor #341

danmash opened this issue Jun 21, 2022 · 0 comments
Labels
refactoring

Comments

@danmash
Copy link
Member

danmash commented Jun 21, 2022 •
edited
Loading

What to refactor?

  • Currently, there are plenty of loops across G.nodes list which could be optimized in some way.
  • app/network_x_tools/network_x_processor.py could be also used to do general operations with DiGraph (G) such as:
    • search.
    • get effects
    • get solutions

Refactor reason

Code duplication and PEP8

Tests

  • unit tests
@danmash danmash added the enhancement New feature or request label Jun 21, 2022
@danmash danmash added refactoring and removed enhancement New feature or request labels Jul 20, 2022
@danmash danmash changed the title upgrade network_x_processor Refactor network_x_processor Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactoring
Projects
Climate Mind Web App
Status: 📋 Backlog
Milestone
No milestone
Development

No branches or pull requests
1 participant
@danmash