Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor feed Blueprint usage #469

Open
3 tasks
danmash opened this issue Dec 6, 2022 · 0 comments
Open
3 tasks

Refactor feed Blueprint usage #469

danmash opened this issue Dec 6, 2022 · 0 comments
Labels
good first issue Good for newcomers refactoring

Comments

@danmash
Copy link
Member

danmash commented Dec 6, 2022

What to refactor?

  • app/feed/routes.py use feed bp instead of scores

https://github.com/ClimateMind/climatemind-backend/blob/develop/app/feed/routes.py#L4

  • app/feed/tests/test_feed_routes.py

Refactor reason

In #464 @brianpeiris noticed that we used the wrong Blueprint object in the feed.

Tests

  • fix unit tests app/feed/tests/test_feed_routes.py
  • check other usages for scoring.get_feed string and other URL usages
  • check that this will not break the feed
@danmash danmash added refactoring good first issue Good for newcomers labels Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers refactoring
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@danmash