Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ft/codeforafrica Navigation CMS setup #511

Merged
merged 71 commits into from
Sep 5, 2023
Merged

Ft/codeforafrica Navigation CMS setup #511

merged 71 commits into from
Sep 5, 2023

Conversation

kelvinkipruto
Copy link
Contributor

@kelvinkipruto kelvinkipruto commented Jul 20, 2023 •
edited by github-actions bot
Loading

Description

This PR setups Navigation from CMS.

Fixes #509

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Screenshots

image

image

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

Preview

Preview URL

@vercel
Copy link

vercel bot commented Jul 20, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
codeforafrica ❌ Failed (Inspect) Jul 31, 2023 3:19pm

@koechkevin koechkevin changed the base branch from main to develop July 21, 2023 06:15
@kelvinkipruto kelvinkipruto changed the base branch from develop to main July 21, 2023 07:06
@kelvinkipruto kelvinkipruto changed the base branch from main to develop July 21, 2023 07:21
@kelvinkipruto kelvinkipruto force-pushed the ft/codeforafrica-navigation-cms branch from 9c58762 to 4132295 Compare July 24, 2023 12:59
@vercel
Copy link

vercel bot commented Jul 24, 2023

Deployment failed with the following error:

`functions.excludeFiles` should be object

koechkevin
koechkevin reviewed Aug 31, 2023
View reviewed changes
Copy link
Contributor

@koechkevin koechkevin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also fix the images on 404 pages @kelvinkipruto

@kelvinkipruto
Copy link
Contributor Author

kelvinkipruto commented Aug 31, 2023 •
edited
Loading

@koechkevin Images on 404 are loading on my side https://codeforafrica-ui-pr-511.dev.codeforafrica.org/404

@kelvinkipruto kelvinkipruto force-pushed the ft/codeforafrica-navigation-cms branch from 9e1d141 to caf26e6 Compare September 4, 2023 16:20
@kelvinkipruto
Merge branch 'develop' into ft/codeforafrica-navigation-cms
0083a29 
Signed-off-by: Kipruto <43873157+kelvinkipruto@users.noreply.github.com>
@kelvinkipruto
Rebase navigation code
9ab517b
kilemensi
kilemensi reviewed Sep 5, 2023
View reviewed changes
Copy link
Member

@kilemensi kilemensi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

Dockerfile.codeforafrica Outdated Show resolved Hide resolved
apps/codeforafrica/src/components/NavBarNavList/NavBarNavList.js Outdated Show resolved Hide resolved
apps/codeforafrica/src/components/NavBarNavList/NavBarNavList.js Outdated Show resolved Hide resolved
apps/codeforafrica/src/components/NavBarNavList/NavBarNavList.js Outdated Show resolved Hide resolved
apps/codeforafrica/src/components/NavBarNavList/NavBarNavList.test.js Outdated Show resolved Hide resolved
apps/codeforafrica/src/lib/data/common/navigation.js Outdated Show resolved Hide resolved
apps/codeforafrica/src/payload/collections/Media.js Outdated Show resolved Hide resolved
@kilemensi kilemensi mentioned this pull request Sep 5, 2023
Merged
12 tasks
kilemensi
kilemensi approved these changes Sep 5, 2023
View reviewed changes
Copy link
Member

@kilemensi kilemensi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

apps/codeforafrica/src/lib/data/common/navigation.js Outdated Show resolved Hide resolved
apps/codeforafrica/src/pages/404.page.js Show resolved Hide resolved
apps/codeforafrica/src/payload/fields/links/link.js Show resolved Hide resolved
@koechkevin koechkevin mentioned this pull request Sep 5, 2023
Open
@kelvinkipruto kelvinkipruto merged commit 9509377 into develop Sep 5, 2023
4 checks passed
@kelvinkipruto kelvinkipruto deleted the ft/codeforafrica-navigation-cms branch September 5, 2023 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koechkevin koechkevin koechkevin approved these changes

@kilemensi kilemensi kilemensi approved these changes

Assignees

@kelvinkipruto kelvinkipruto

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

@/codeforafrica global Navigation
3 participants
@kelvinkipruto @kilemensi @koechkevin