Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initiate action should/could be specified in URL #17

Open
timwis opened this issue Sep 30, 2016 · 0 comments
Open

Initiate action should/could be specified in URL #17

timwis opened this issue Sep 30, 2016 · 0 comments

Comments

@timwis
Copy link
Member

timwis commented Sep 30, 2016

The way the client is designed, it gets the workflow definition from GET /api/travel-request/. If there's an id property, it renders the data and the events. If there's multiple state.actions, it renders action buttons. If there's only 1 state.actions, it renders the form for it. If there's more than 1 state.actions, it waits until you select one of the action buttons, and renders that form. On submission, the form posts to POST /api/travel-request/<case-id?>/<action-slug>?token=xx.

At the moment, this fails on the initiate action, I think because by design we expected clients to not include the action on the initiate POST. But it's actually pretty simple to do that since (a) we're providing the name of the action in the response to their GET request, and (b) they're already using part of that response for their POST request (the template).

My guess is you probably added extra logic to identify what the default action was. Perhaps this isn't necessary, and we can just expect clients to include the action name in every POST request.

Thoughts @mjumbewu ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant