From 49fd34afcc11a627a9a82c537e1b0b6d0276be05 Mon Sep 17 00:00:00 2001 From: Michael Bangas Date: Thu, 3 Aug 2023 14:25:03 +0200 Subject: [PATCH] Reactivate tests #525 This change reactivates all working disabled tests from project org.eclipse.debug.tests. The tests were forgotten after the corresponding bug was fixed. Contributes to #525 --- .../debug/tests/breakpoint/SerialExecutorTest.java | 2 -- .../debug/tests/console/ConsoleDocumentAdapterTests.java | 3 ++- .../eclipse/debug/tests/viewer/model/ContentTests.java | 3 ++- .../debug/tests/viewer/model/JFaceViewerDeltaTests.java | 9 --------- 4 files changed, 4 insertions(+), 13 deletions(-) diff --git a/debug/org.eclipse.debug.tests/src/org/eclipse/debug/tests/breakpoint/SerialExecutorTest.java b/debug/org.eclipse.debug.tests/src/org/eclipse/debug/tests/breakpoint/SerialExecutorTest.java index 0ac6bd73dd1..6d748a35401 100644 --- a/debug/org.eclipse.debug.tests/src/org/eclipse/debug/tests/breakpoint/SerialExecutorTest.java +++ b/debug/org.eclipse.debug.tests/src/org/eclipse/debug/tests/breakpoint/SerialExecutorTest.java @@ -23,7 +23,6 @@ import org.eclipse.core.runtime.jobs.Job; import org.eclipse.debug.internal.ui.model.elements.SerialExecutor; import org.eclipse.debug.tests.AbstractDebugTest; -import org.junit.Ignore; import org.junit.Test; @SuppressWarnings("restriction") @@ -118,7 +117,6 @@ public void testSchedulingQueue() throws InterruptedException { } @Test - @Ignore("See https://bugs.eclipse.org/bugs/show_bug.cgi?id=574883") public void testHeavyScheduling() throws InterruptedException { // Executor has to execute every task. Even when they are scheduled fast // and execute fast diff --git a/debug/org.eclipse.debug.tests/src/org/eclipse/debug/tests/console/ConsoleDocumentAdapterTests.java b/debug/org.eclipse.debug.tests/src/org/eclipse/debug/tests/console/ConsoleDocumentAdapterTests.java index f2b58e55d93..62b1ecfbd5a 100644 --- a/debug/org.eclipse.debug.tests/src/org/eclipse/debug/tests/console/ConsoleDocumentAdapterTests.java +++ b/debug/org.eclipse.debug.tests/src/org/eclipse/debug/tests/console/ConsoleDocumentAdapterTests.java @@ -939,7 +939,8 @@ public void testChangeDocument() { /** * Test if invalid arguments produces error log messages. */ - public void _testInvalidInvocations() { + @Test + public void testInvalidInvocations() { final AtomicInteger expectedErrors = new AtomicInteger(0); final ILogListener logListener = new ILogListener() { @Override diff --git a/debug/org.eclipse.debug.tests/src/org/eclipse/debug/tests/viewer/model/ContentTests.java b/debug/org.eclipse.debug.tests/src/org/eclipse/debug/tests/viewer/model/ContentTests.java index 6133a9620d8..18be2840a6c 100644 --- a/debug/org.eclipse.debug.tests/src/org/eclipse/debug/tests/viewer/model/ContentTests.java +++ b/debug/org.eclipse.debug.tests/src/org/eclipse/debug/tests/viewer/model/ContentTests.java @@ -254,7 +254,8 @@ public void testLabelUpdatesCompletedOutOfSequence2() throws Exception { * point, then this test should be re-enabled.
* See bug 210027 */ - public void _x_testChildrenUpdatesCompletedOutOfSequence() throws Exception { + @Test + public void testChildrenUpdatesCompletedOutOfSequence() throws Exception { TestModelWithCapturedUpdates model = new TestModelWithCapturedUpdates(); model.fCaptureChildrenUpdates = true; diff --git a/debug/org.eclipse.debug.tests/src/org/eclipse/debug/tests/viewer/model/JFaceViewerDeltaTests.java b/debug/org.eclipse.debug.tests/src/org/eclipse/debug/tests/viewer/model/JFaceViewerDeltaTests.java index 6e131c8aecf..08d49434f65 100644 --- a/debug/org.eclipse.debug.tests/src/org/eclipse/debug/tests/viewer/model/JFaceViewerDeltaTests.java +++ b/debug/org.eclipse.debug.tests/src/org/eclipse/debug/tests/viewer/model/JFaceViewerDeltaTests.java @@ -20,7 +20,6 @@ import org.eclipse.swt.SWT; import org.eclipse.swt.widgets.Display; import org.eclipse.swt.widgets.Shell; -import org.junit.Test; /** * @since 3.6 @@ -31,12 +30,4 @@ public class JFaceViewerDeltaTests extends DeltaTests { protected IInternalTreeModelViewer createViewer(Display display, Shell shell) { return new TreeModelViewer(fShell, SWT.VIRTUAL, new PresentationContext("TestViewer")); //$NON-NLS-1$ } - - /** - * TODO: remove this method when bug 292322 gets fixed in TreeViewer - */ - @Override - @Test - public void testBug292322() { - } }