You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This sadly breaks types with older versions of Esbuild and I started getting this error on build:
16.16 vite.config.ts(153,11): error TS2322: Type 'import("/node_modules/esbuild/lib/main").Plugin' is not assignable to type 'import("/node_modules/vite/node_modules/esbuild/lib/main").Plugin'.
16.16 Types of property 'setup' are incompatible.
16.16 Type '(build: import("/node_modules/esbuild/lib/main").PluginBuild) => void | Promise<void>' is not assignable to type '(build: import("/node_modules/vite/node_modules/esbuild/lib/main").PluginBuild) => void | Promise<void>'.
16.16 Types of parameters 'build' and 'build' are incompatible.
16.16 Type 'import("/node_modules/vite/node_modules/esbuild/lib/main").PluginBuild' is not assignable to type 'import("/node_modules/esbuild/lib/main").PluginBuild'.
16.16 Types of property 'onResolve' are incompatible.
16.16 Type '(options: import("/node_modules/vite/node_modules/esbuild/lib/main").OnResolveOptions, callback: (args: import("/node_modules/vite/node_modules/esbuild/lib/main").OnResolveArgs) => import("/node_modules/vite/node_modules/esbuild/lib/main").OnResolveResult | ... 2 more ... | undefined) => void' is not assignable to type '(options: import("/node_modules/esbuild/lib/main").OnResolveOptions, callback: (args: import("/node_modules/esbuild/lib/main").OnResolveArgs) => import("/node_modules/esbuild/lib/main").OnResolveResult | Promise<...> | null | undefined) => void'.
16.16 Types of parameters 'callback' and 'callback' are incompatible.
16.16 Types of parameters 'args' and 'args' are incompatible.
16.16 Property 'with' is missing in type 'import("/node_modules/vite/node_modules/esbuild/lib/main").OnResolveArgs' but required in type 'import("/node_modules/esbuild/lib/main").OnResolveArgs'.
I think the idea is to use peerDependencies for this. That said, I have no clue how this resolves if vite uses its own esbuild version. Is node module resolver smart enough to use that esbuild, I would assume so?!
The text was updated successfully, but these errors were encountered:
Esbuild v0.21.4 introduced a small change.
This sadly breaks types with older versions of Esbuild and I started getting this error on build:
I think the idea is to use peerDependencies for this. That said, I have no clue how this resolves if vite uses its own esbuild version. Is node module resolver smart enough to use that esbuild, I would assume so?!
The text was updated successfully, but these errors were encountered: