Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

commitable_code_suggestions property is ignored if git provider doesn't support gfm_markdown #1074

Open
MarkRx opened this issue Jul 29, 2024 · 1 comment
Labels

Comments

@MarkRx
Copy link
Contributor

MarkRx commented Jul 29, 2024

The commitable_code_suggestions feature property is ignored for non github providers.

Looks like the gfm_markdown check in this if statement causes the statement to always be false thereby causing the code to enter the else case which publishes committable code suggestions.

There thus is no way to disable committable code suggestions which is problematic due to #1076

@mrT23
Copy link
Collaborator

mrT23 commented Jul 30, 2024

I don't understand this issue. Can you offer (and implement) a viable alternative, given Bitbucket's major limitations ?

Bitbucket is the only git provider that does not provide basic support for graphical elements like collapsible (or in general gfm markdown)

All other git providers, a.k.a github,gitlab, azure .... do support that. It's the standart.

Hence, we cannot present results in a comment-like manner in Bitbucket since they will take a ridiculous amount of space.
So we must publish them as commitable suggestions, one-by-one.

I don't like this mode. Suggestions in a single comment are dramatically better in my opinion. But we cant do that in Bitbucket, since its an inferior provider, not maintained or improved in the last ~10years.

If you are paying money for Bitbucket, I suggest you contact them, and demand they will add support for gfm. its extremely basic. We are not the first to want this, another.

Without minimal graphical support, we have no alternative but to publish only as commitable_code_suggestions.
Its too much data for a single-comment, when collapsible are not supported

collapsible collapsible content

collapsible content

collapsible content

collapsible content

collapsible content

collapsible content

collapsible content

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants