Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to delete all events #18

Open
sebdeveloper6952 opened this issue Apr 1, 2024 · 6 comments
Open

Option to delete all events #18

sebdeveloper6952 opened this issue Apr 1, 2024 · 6 comments

Comments

@sebdeveloper6952
Copy link

I find this packaged relay very useful for development, and I think an option for deleting all events could be useful too. What do you think?

@CodyTseng
Copy link
Owner

Great idea! We can add a delete method to the EventRepository interface, with an optional filter parameter. Would you like to open a PR to implement this feature?

@sebdeveloper6952
Copy link
Author

sebdeveloper6952 commented Apr 2, 2024

That sounds good! Yes I would like to implement this feature, I'll open the PR.

I just realized I meant to open this PR on the nostr-relay-tray repo. Do you think it's still best to start at this repo and then implement it over there?

@CodyTseng
Copy link
Owner

Nostr-relay-tray started as a mere demo, very rudimentary and not easy to further develop. I plan to rewrite it, so please hold off on opening PRs for it for now. 🤗

@sebdeveloper6952
Copy link
Author

Understood.

@sebdeveloper6952
Copy link
Author

@CodyTseng for the EventRepository interface delete method, what should the return type be? I was thinking of returning the number of deleted events.

@CodyTseng
Copy link
Owner

I think it's good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants