Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Drag and Drop Embedding from Model Library #1029

Open
1 task done
silveroxides opened this issue Sep 27, 2024 · 2 comments
Open
1 task done

[Feature Request]: Drag and Drop Embedding from Model Library #1029

silveroxides opened this issue Sep 27, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@silveroxides
Copy link

Is there an existing issue for this?

  • I have searched the existing issues and checked the recent builds/commits

What would your feature do ?

I suggest a feature that would allow dragging a model from the Model Library menu onto a node containing a text box to add the path to the model in the text box.
Primarily for Embeddings to ease the adding of them to prompt for the user.

Additionally I suggest feature that if you drag a model onto a blank canvas, the search box opens and filters what nodes are able to load models from that models directory and final suggestion is if you drop a model onto an existing loader of appropriate type, it attempts to locate the model and set that to the appropriate INPUT_TYPES using folder_paths module. (checkpoints, loras, vae and vae_approx, controlnet, clip, diffusion_models, etc.)
I include image examples of the first suggestion.
yMKRBJxru4

Proposed workflow

Refer to feature description as it describes this.

Additional information

No response

@silveroxides silveroxides added the enhancement New feature or request label Sep 27, 2024
@JorgeR81
Copy link

There is already a PR ( #1004 ) for Drag and Drop models onto existing nodes.

But I'm not sure if it includes embeddings, at the moment.
That would be nice too.


The autocomplete feature, from pythongosssss is a good alternative, but it only supports 20 entries.

https://github.com/pythongosssss/ComfyUI-Custom-Scripts

emb

@silveroxides
Copy link
Author

@JorgeR81 I already use the autocomplete one but it is kind of completely backwards, have poor alias support, no frequency database collection or any of the neat features that the tagautocomplete extension for a1111 has. Also I was requested by @mcmonkey4eva to make this issue after I brought it up in the discord server so that there was something to reference to on the repo.

@mcmonkey4eva mcmonkey4eva changed the title [Feature Request]: Drag and Drop from Model Library [Feature Request]: Drag and Drop Embedding from Model Library Sep 28, 2024
@mcmonkey4eva mcmonkey4eva self-assigned this Sep 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants