Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

external function for constructing paras vector? #62

Open
jejoenje opened this issue May 18, 2020 · 0 comments
Open

external function for constructing paras vector? #62

jejoenje opened this issue May 18, 2020 · 0 comments
Labels
Suggested feature New things to add to GMSE

Comments

@jejoenje
Copy link
Collaborator

Currently, I note gmse.R and gmse_apply.R each separately construct the paras vector, even though its structure, I think, is expected to be exactly the same in both; consisting partially of dynamic variables and partially of a set of constants referring to locations in arrays, etc.

I wonder whether it would be useful to have a separate function, whose only job it is to construct paras from only the set of variables it includes - which can be called from either gmse or gmse_apply?

I'd be happy to suggest a change that does this, but there may be limitations/constraints on this that I haven't identified yet.
Possible upside - it would avoid some replication in code between gmse.R and gmse_apply.R.
Possible downside - it would require a separate function (and possibly file) that can be sourced by both the above functions.

@jejoenje jejoenje added the Suggested feature New things to add to GMSE label May 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Suggested feature New things to add to GMSE
Projects
None yet
Development

No branches or pull requests

1 participant