-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem with mem_prv_observ
argument
#76
Comments
bradduthie
added a commit
that referenced
this issue
Aug 3, 2021
…' to '0' in manager function for C. @AdrianBach -- would be could to double check that this if-else is necessary?
I've now swapped the line so that it reads as follows:
This should be okay then, but it's still not quite clear that the if/else is needed? |
Hi @bradduthie ! Hope all is well ! Yes, this if else is needed because mem == 0 corresponds to the ATI strategy and mem > 0 to TRJ strategy. Is this the if else you are talking about? Cheers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The
mem_prv_observ
argument takes a boolean value, but it is unclear to me why we would ever need this value to beTRUE
. Should it not always beTRUE
when using the trajectory method of prediction?Additionally, there is an error in the code on this line, which reads:
FALSE
is equivalent to 0 in R, but not C, so I will change this to 0. and push a new version.The text was updated successfully, but these errors were encountered: