Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get Traces Limits From prover/backend/config package. #52

Merged
merged 5 commits into from
Nov 9, 2023

Conversation

alesforz
Copy link
Contributor

@alesforz alesforz commented Nov 8, 2023

Context

In this issue we are adding a new config pkg responsible for reading in TOML configuration files defining configuration variables for the prover.
The existing corset code responsible for producing a WizardIOP constraint system assumes that said configuration variables (the traces limits) are hard-coded as go constants (e.g., see these two files).

As part of the issue linked above, the new config pkg reads in the traces limits from the configuration file, then subsequent code embeds them into a *zkevm.Builder object passed as parameter here. Therefore, the corset code has to slightly change to now read the traces limits from this object.

This Change

The only change is the formatting string in the wizardiop.rs responsible for generating the go code.

Test

Tested the change with

cargo run -- wizard-iop -o  $WORKSPACE/zkevm-constraints/mxp $WORKSPACE/zkevm-constraints/lookup_tables/tables/instruction_decoder.lisp

@alesforz alesforz requested a review from delehef November 8, 2023 14:23
@delehef delehef merged commit 0a489d0 into master Nov 9, 2023
2 checks passed
@delehef delehef deleted the use-prover-config-pkg branch November 9, 2023 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants