Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaning finite field generators #566

Open
ThomasPiellard opened this issue Dec 6, 2024 · 0 comments
Open

Cleaning finite field generators #566

ThomasPiellard opened this issue Dec 6, 2024 · 0 comments

Comments

@ThomasPiellard
Copy link
Contributor

ThomasPiellard commented Dec 6, 2024

when using a finite field (e.g. "../bn254/fr"):

  • fr.Generator should be renamed fr.GenBiggestTwoAdicSubgroup or something explaining exactly what the generator in question is
  • GeneratorFullMultiplicativeGroup, which is in the FFT package for now, should be in the finite fields package, it should be named fr.GeneratorMultiplicativeGroup() or just fr.Generator (this time there is no ambiguity about what the generator does)

Those little modifications would help cleaning the templates for the fft code generation (which should depend only on the FieldConfig) and would clarify the api

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant