You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
fr.Generator should be renamed fr.GenBiggestTwoAdicSubgroup or something explaining exactly what the generator in question is
GeneratorFullMultiplicativeGroup, which is in the FFT package for now, should be in the finite fields package, it should be named fr.GeneratorMultiplicativeGroup() or just fr.Generator (this time there is no ambiguity about what the generator does)
Those little modifications would help cleaning the templates for the fft code generation (which should depend only on the FieldConfig) and would clarify the api
The text was updated successfully, but these errors were encountered:
when using a finite field (e.g. "../bn254/fr"):
fr.Generator
should be renamed fr.GenBiggestTwoAdicSubgroup or something explaining exactly what the generator in question isGeneratorFullMultiplicativeGroup
, which is in the FFT package for now, should be in the finite fields package, it should be namedfr.GeneratorMultiplicativeGroup()
or justfr.Generator
(this time there is no ambiguity about what the generator does)Those little modifications would help cleaning the templates for the fft code generation (which should depend only on the
FieldConfig
) and would clarify the apiThe text was updated successfully, but these errors were encountered: