Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add zkalc scripts to develop #434

Closed
wants to merge 12 commits into from
Closed

Add zkalc scripts to develop #434

wants to merge 12 commits into from

Conversation

yelhousni
Copy link
Collaborator

zkalc branch has some scripts to benchmark gnark-crypto which is now behind develop optimizations #432. Either we can merge this PR to add the scripts to develop (and master) or automate the process so that the branch track develop.

@yelhousni yelhousni added the consolidate strengthen an existing feature label Jul 22, 2023
@CLAassistant
Copy link

CLAassistant commented Jul 22, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 4 committers have signed the CLA.

✅ mmaker
✅ yelhousni
❌ asn-d6
❌ nalinbhardwaj
You have signed the CLA already but the status is still pending? Let us recheck it.

@yelhousni yelhousni marked this pull request as draft July 22, 2023 09:53
@yelhousni
Copy link
Collaborator Author

draft for now as the tests need to be cleaned: I forgot that in zkalc branch I got rid of windowed scalar multiplication to bench only GLV scalar mul (the fastest between the two).

zkalc's benchmarks: fp -> fr
@gbotrel gbotrel changed the base branch from develop to master August 22, 2023 21:08
@yelhousni yelhousni self-assigned this Jun 12, 2024
@yelhousni
Copy link
Collaborator Author

zkalc branch is up to date with master

@yelhousni yelhousni closed this Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
consolidate strengthen an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants