feat: 172 trace alignment #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates the notion of a `Trace` and `Schema` to support "column groups". Furthermore, the concept of alignment between a `Trace` and `Schema` is introduced.
This implements `AlignWith` on `Trace` which is used to align a trace with a schema.
This puts through a partial (yet incomplete) switch from column names to column indices for accessing columns at the AIR level.
This updates MIR to use direct column access. The conversion is not complete however, as there are some components which are still using names. Unfortunately, this change has also highlighted some serious weaknesses in the current mechanism for lowering from high-level to lower-levels.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This partially moves the system towards using column indices rather than column names as the primary mechanism for identifying columns. The conversion is not complete however, as there are some components which are still using names. Unfortunately, this change has also highlighted some serious weaknesses in the current mechanism for lowering from high-level to lower-levels.